Skip to content
This repository has been archived by the owner on Jun 18, 2024. It is now read-only.

Removed IntelliJ files #536

Merged
merged 1 commit into from
Oct 18, 2016
Merged

Removed IntelliJ files #536

merged 1 commit into from
Oct 18, 2016

Conversation

vanta
Copy link
Contributor

@vanta vanta commented Jun 16, 2016

Related to #454

@azurecla
Copy link

Hi @vanta, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.

TTYL, AZPRBOT;

@codecov-io
Copy link

Current coverage is 10.43%

No coverage report found for master at 7f8793a.

Powered by Codecov. Last updated by 7f8793a...c217d02

@serious6
Copy link
Member

serious6 commented Oct 8, 2016

@vanta the reason why we made the integration of the idea specific project files is that we wanted people to be enforced to use the documented formatter. From my point of view just removing the files does not resolve the conflict. Any comments?

@vanta
Copy link
Contributor Author

vanta commented Oct 8, 2016

@serious6 Thanks for your comment. I've got your point. I'm an IntelliJ user as well so glad to hear that but how about other IDEs' users? Formatting still can be messed up as the is no way to enforce formatting in IDE (user can always change it or don't format).

Maybe this formatting check can be one of build steps (by using some plugin)?

Copy link
Member

@serious6 serious6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Formating should be added to the build later on.

@serious6 serious6 merged commit 0e1ba52 into OfficeDev:master Oct 18, 2016
@serious6
Copy link
Member

@vanta thanks for your support.

thorstenschiffer added a commit to thorstenschiffer/ews-java-api that referenced this pull request May 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants